Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor wrapper generation, and enable fastcall for static/class methods. #1660

Merged
merged 3 commits into from
Jun 6, 2021
Merged

Refactor wrapper generation, and enable fastcall for static/class methods. #1660

merged 3 commits into from
Jun 6, 2021

Conversation

birkenfeld
Copy link
Member

So I managed it after all...

This has, unfortunately, pretty large changes moving stuff around which are not very review friendly. I suggest to look mostly at the new code.

impl_arg_param(s) are just moved, no changes to review there.

@birkenfeld birkenfeld mentioned this pull request Jun 5, 2021
Merged
davidhewitt
davidhewitt approved these changes Jun 5, 2021
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is absolutely brilliant; I'd been wondering about a similar refactoring but never got around to it.

Really happy with the new code arrangement and adds a performance optimization on top! 💯

@birkenfeld birkenfeld merged commit 4d2c173 into main Jun 6, 2021
@birkenfeld birkenfeld deleted the method_defs branch June 6, 2021 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@birkenfeld @davidhewitt